[
https://issues.apache.org/jira/browse/SOLR-12584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638420#comment-16638420
]
Jan Høydahl commented on SOLR-12584:
------------------------------------
Thanks for contributing. I just skimmed the patch, and a few piece of advice to
start with
* Please read
[https://wiki.apache.org/solr/HowToContribute#Creating_the_patch_file]
* In particular, name the file SOLR-12584.patch and avoid unrelated whitespace
changes
* I also see some unnecessary comments, some new lines that are commented out
etc. Please clean up, the patch should then be much smaller
Also, see my comment from August where I propose that
{quote}It should probably support the same env vars and password file as
bin/solr script does, so that users could configure the Exporter in the same
way they do with Solr itself."
{quote}
What I mean by that is that we should re-use the same way of configuring the
exporter as we already to for configuring Solr itself and e.g. the {{bin/solr}}
script, which is by setting two env.variables. See copy-paste from solr.in.sh:
{noformat}
# Settings for authentication
# Please configure only one of SOLR_AUTHENTICATION_CLIENT_BUILDER or
SOLR_AUTH_TYPE parameters
#SOLR_AUTHENTICATION_CLIENT_BUILDER="org.apache.solr.client.solrj.impl.PreemptiveBasicAuthClientBuilderFactory"
#SOLR_AUTH_TYPE="basic"
#SOLR_AUTHENTICATION_OPTS="-Dbasicauth=solr:SolrRocks"
{noformat}
This will also allow for type 'kerberos' and future auth types that may be
invented later.
> Add basic auth credentials configuration to the Solr exporter for
> Prometheus/Grafana
> --------------------------------------------------------------------------------------
>
> Key: SOLR-12584
> URL: https://issues.apache.org/jira/browse/SOLR-12584
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Authentication, metrics, security
> Affects Versions: 7.3, 7.4
> Reporter: Dwane Hall
> Priority: Minor
> Labels: authentication, metrics, security
> Attachments: lucene-solr.patch
>
>
> The Solr exporter for Prometheus/Grafana provides a useful visual layer over
> the solr metrics api for monitoring the state of a Solr cluster. Currently
> this can not be configured and used on a secure Solr cluster with the Basic
> Authentication plugin enabled. The exporter does not provide a mechanism to
> configure/pass through basic auth credentials when SolrJ requests information
> from the metrics api endpoints and would be a useful addition for Solr users
> running a secure Solr instance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
