GitHub user tpunder opened a pull request:

    https://github.com/apache/lucene-solr/pull/470

    SOLR-12874 - Java 9+ GC Logging filesize parameter should be 20M instead of 
20000

    JEP 158 (https://openjdk.java.net/jeps/158) says the filesize parameter is 
the “file size in kb” however that appears to not be the case since when it 
is set to a value of 20000 you end up with GC logs that are only 20000 bytes in 
length.  Setting the value to 20M produces the desired result of GC log files 
that are 20MB in size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tpunder/lucene-solr 
java9plus_gc_logging_filesize

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/470.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #470
    
----
commit 5202a713baad4c7b743ad5ccd5db2bc079672d84
Author: Tim Underwood <timunderwood@...>
Date:   2018-10-15T19:52:12Z

    Java 9+ GC Logging filesize parameter should be 20M instead of 20000
    
    JEP 158 (https://openjdk.java.net/jeps/158) says the filesize parameter is 
the “file size in kb” however that appears to not be the case since when it 
is set to a value of 20000 you end up with GC logs that are only 20000 bytes in 
length.  Setting the value to 20M produces the desired result of GC log files 
that are 20MB in size.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to