[ 
https://issues.apache.org/jira/browse/LUCENE-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653188#comment-16653188
 ] 

Simon Willnauer commented on LUCENE-6572:
-----------------------------------------

> I also don't understand why it depends on join. So messy

that's a mess too and a general problem with highligiting. It's because we 
don't have a good way to extract the parent/child query to do the highlighting. 
One way of doing this would be to have a simple interface or query subclass 
that we can also extend ConstantScoreQuery from that has a `getQuery()` method. 
I am not sure we want this to be in core?

> Highlighter depends on analyzers-common
> ---------------------------------------
>
>                 Key: LUCENE-6572
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6572
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>            Reporter: Robert Muir
>            Assignee: Simon Willnauer
>            Priority: Blocker
>         Attachments: LUCENE-6572.patch, LUCENE-6572.patch
>
>
> This is a huge WTF, just for "LimitTokenOffsetFilter" which is only useful 
> for highlighting.
> Adding all these intermodule dependencies makes things too hard to use.
> This is a 5.3 release blocker.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to