[ 
https://issues.apache.org/jira/browse/SOLR-8339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653292#comment-16653292
 ] 

Gregor B. Rosenauer edited comment on SOLR-8339 at 10/17/18 9:59 AM:
---------------------------------------------------------------------

I am upgrading an old 5.4.1 codebase to 7.5.0 and found there is no replacement 
for the now removed method {{ClientUtils.toSolrInputDocument()}}.

What's the correct way to handle this, without reimplementing the old code 
(what's the point then?).

Maybe the patch should be extended to {{SolrClient.add}} accept a 
{{SolrDocumentBase}} instead of only {{SolrInputDocument}}?


was (Author: grexe):
I am upgrading an old 5.4.1 codebase and found there is no replacement for the 
now removed method \{{ClientUtils.toSolrInputDocument()}}.

What's the correct way to handle this, without reimplementing the old code 
(what's the point then?).

Maybe the patch should be extended to \{{SolrClient.add}} accept a 
{{SolrDocumentBase}} instead of only {{SolrInputDocument}}?

> SolrDocument and SolrInputDocument should have a common interface
> -----------------------------------------------------------------
>
>                 Key: SOLR-8339
>                 URL: https://issues.apache.org/jira/browse/SOLR-8339
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Shalin Shekhar Mangar
>            Priority: Major
>             Fix For: 5.5, 6.0
>
>         Attachments: SOLR-8339.patch, SOLR-8339.patch, SOLR-8339.patch, 
> SOLR-8339.patch
>
>
> Currently, both share a Map interface (SOLR-928). However, there are many 
> common methods like createField(), setField() etc. that should perhaps go 
> into an interface/abstract class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to