[
https://issues.apache.org/jira/browse/LUCENE-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-3348:
---------------------------------------
Attachment: LUCENE-3348.patch
Initial patch, tons of nocommits still but tests pass.
I moved the Lucene-only test over to oal.index, and added VERBOSE
prints.
I made an initial possible fix for the first failure, which seems to
work (I don't seem to hit that failure anymore). I'm not sure I like
the fix... basically, after pulling the DWPT for indexing, I check if
it's stale, and if so call a new method in DWFlushControl to move that
DWPT into the toFlush list. I think it'd be better to somehow, up
front in flush-all, mark all current DWPTs as stale, pull them out of
rotation, so that the thread pool would never return such a stale
DWPT.
Still trying to understand the 2nd failure...
> IndexWriter applies wrong deletes during concurrent flush-all
> -------------------------------------------------------------
>
> Key: LUCENE-3348
> URL: https://issues.apache.org/jira/browse/LUCENE-3348
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.4, 4.0
>
> Attachments: LUCENE-3348.patch
>
>
> Yonik uncovered this with the TestRealTimeGet test: if a flush-all is
> underway, it is possible for an incoming update to pick a DWPT that is
> stale, ie, not yet pulled/marked for flushing, yet the DW has cutover
> to a new deletes queue. If this happens, and the deleted term was
> also updated in one of the non-stale DWPTs, then the wrong document is
> deleted and the test fails by detecting the wrong value.
> There's a 2nd failure mode that I haven't figured out yet, whereby 2
> docs are returned when searching by id (there should only ever be 1
> doc since the test uses updateDocument which is atomic wrt
> commit/reopen).
> Yonik verified the test passes pre-DWPT, so my guess is (but I
> have yet to verify) this test also passes on 3.x. I'll backport
> the test to 3.x to be sure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
