[
https://issues.apache.org/jira/browse/SOLR-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072526#comment-13072526
]
Martijn van Groningen edited comment on SOLR-2665 at 7/28/11 8:54 PM:
----------------------------------------------------------------------
bq. I'm uploading a patch isolating this error and a fix.
Thanks Tomas!
{quote}
Also, I don't know why, but the test case testGroupingSortByFunction with the
extra line you added on the previous patch
assertU(add(doc("id", "6", "value1_i", "1", "value2_i", "5", "store",
"45.18014,-93.87746")));
didn't run correctly for me, I'm not sure why should it run. I didn't touch
that line but that test doesn't run for me.
{quote}
Oops. That is a copy / past error. That test shouldn't never have been changed.
bq. If this essentially drops documents after the group.limit in each group,
how about naming the parameter group.truncate?
I think that is a better name, than there is now. I'll change the group.after
parameter into group.trancate.
was (Author: martijn.v.groningen):
bq. I'm uploading a patch isolating this error and a fix.
Thanks Tomas!
{quote}
Also, I don't know why, but the test case testGroupingSortByFunction with the
extra line you added on the previous patch
assertU(add(doc("id", "6", "value1_i", "1", "value2_i", "5", "store",
"45.18014,-93.87746")));
didn't run correctly for me, I'm not sure why should it run. I didn't touch
that line but that test doesn't run for me.
{quote}
Oops. That is a copy / past error. That test shouldn't never have been changed.
bq. If this essentially drops documents after the group.limit in each group,
how about naming the parameter group.truncate?
I think that is a better name, than there is now. I'll change the group.after
into group.trancate.
> Solr Post Group Faceting
> ------------------------
>
> Key: SOLR-2665
> URL: https://issues.apache.org/jira/browse/SOLR-2665
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 3.3
> Reporter: Bill Bell
> Assignee: Martijn van Groningen
> Fix For: 3.4, 4.0
>
> Attachments: SOLR-2665.patch, SOLR-2665.patch
>
>
> Once Lucene is wired, add this feature to Solr.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
