[ https://issues.apache.org/jira/browse/LUCENE-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663911#comment-16663911 ]
Ignacio Vera edited comment on LUCENE-8534 at 10/25/18 4:39 PM: ---------------------------------------------------------------- [~nknize] attached is a patch with some findings: 1.- Method Tesellator#isIntersectingPolygon seems incorrect as it only checks the intersection with the first edge. This seems to cause creation of invalid diagonals when splitting the polygon. 2.- Method Tesellator#cureLocalIntersections produces incorrect ears. I think it needs to call the method above. 3.- when splitting a polygon, it needs to resorted if using Morton indexing. It seems that for doing that the linked list needs to be reseted for Z values. This fixes the issues I had a visual inspection of the tessellation and it is looking good. was (Author: ivera): @nknize, attached is a patch with some findings: 1.- Method Tesellator#isIntersectingPolygon seems incorrect as it only checks the intersection with the first edge. This seems to cause creation of invalid diagonals when splitting the polygon. 2.- Method Tesellator#cureLocalIntersections produces incorrect ears. I think it needs to call the method above. 3.- when splitting a polygon, it needs to resorted if using Morton indexing. It seems that for doing that the linked list needs to be reseted for Z values. This fixes the issues I had a visual inspection of the tessellation and it is looking good. > Another case of Polygon tessellator going into an infinite loop > --------------------------------------------------------------- > > Key: LUCENE-8534 > URL: https://issues.apache.org/jira/browse/LUCENE-8534 > Project: Lucene - Core > Issue Type: Bug > Components: modules/sandbox > Reporter: Ignacio Vera > Priority: Major > Attachments: LUCENE-8534.patch, LUCENE-8534.patch, LUCENE-8534.patch, > bigPolygon.wkt, image-2018-10-19-12-25-07-849.png > > > Related to LUCENE-8454, another case where tesselator never returns when > processing a polygon. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org