Github user vthacker commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/483#discussion_r228304003
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/processor/LogUpdateProcessorFactory.java
 ---
    @@ -187,12 +190,23 @@ public void finish() throws IOException {
             log.info(getLogStringAndClearRspToLog());
           }
     
    +      if (deleteLog.isInfoEnabled()) {
    --- End diff --
    
    What if it's a mixed set of commands like this example : 
http://lucene.apache.org/solr/guide/7_5/uploading-data-with-index-handlers.html#sending-json-update-commands
    
    Is the goal here to log any request that contains a delete or log only 
deletes to a separate file? The final condition check here will need to vary 
based on that


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to