Github user vthacker commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/486#discussion_r229523672
  
    --- Diff: 
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java ---
    @@ -265,10 +281,30 @@ public MiniSolrCloudCluster(int numServers, Path 
baseDir, String solrXml, JettyC
         solrClient = buildSolrClient();
       }
     
    -  private void waitForAllNodes(int numServers, int timeout) throws 
IOException, InterruptedException {
    +  private void waitForAllNodes(int numServers, int timeoutSeconds) throws 
IOException, InterruptedException {
    --- End diff --
    
    Some Javadocs that we could add here :
    
    "This method wait till all Solr JVMs ( Jettys ) are running . It waits upto 
the timeout (in seconds) for the JVMs to be up before throwing 
IllegalStateException"


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to