[ 
https://issues.apache.org/jira/browse/LUCENE-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073228#comment-13073228
 ] 

Adriano Crestani commented on LUCENE-3310:
------------------------------------------

Good point Michael! At least they shouldn't use mutable values in their 
hashcode. The only reason I remember to implement hashcode in qp attributes was 
because Lucene attributes (CharTermAttributeImpl, OffsetAttributeImpl etc) do 
the same.

It sounds like all attribute impls shouldn't be doing that and we should fix. 
Luckily, today, nowhere in Lucene code we use Attribute instances as key or in 
sets, that is why we probably never hit any problems. However, users may be 
hitting problems because of that. I think we should fix it as soon as possible 
as it seems very critical.

Please, let me know if I am missing something.

> FuzzyAttribute ignores min similarity when generating at hashcode(), 
> toString() and equals() methods
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3310
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3310
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/queryparser
>    Affects Versions: 2.9, 2.9.1, 2.9.2, 2.9.3, 2.9.4, 3.0, 3.0.1, 3.0.2, 
> 3.0.3, 3.1, 3.2, 3.3
>            Reporter: Phillipe Ramalho
>
> FuzzyAttribute ignores min similarity when generating at hashcode(), 
> toString() and equals() methods

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to