[
https://issues.apache.org/jira/browse/SOLR-12947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674493#comment-16674493
]
Jason Gerlowski commented on SOLR-12947:
----------------------------------------
Thanks for the feedback guys.
Thanks for the pointer Teny. The stuff I have planned for faceting looks very
similar to what you've got there. The main point of divergence is that the
patch I have attached subclasses QueryRequest (rather than the higher-level
SolrRequest as "facet-helper" does). I made this choice when I was writing it
last week because I wanted the response objects to still have all the getters
that QueryResponse has. A JsonQueryRequest can pass arbitrary params under the
"params" JSON property. If users take advantage of this, then they would
probably like the response from a JsonQueryRequest to still have all the
getters that they're used to for parsing out other common response values
(highlighting info, regular faceting info, etc.). But there might be other
ways around this. I'll think about it and maybe we could use your stuff more
directly. In any case, thanks for the pointer as it helped me organize my
thoughts.
And agreed Jan. The JsonQueryRequest right now takes in a Map<> to represent
more complex queries, which still leaves the user in charge of knowing the
syntax/structure of facets. Builders or other objects that abstract users
further away from building the Map themselves would definitely help here.
> SolrJ Helper for JSON Request API
> ---------------------------------
>
> Key: SOLR-12947
> URL: https://issues.apache.org/jira/browse/SOLR-12947
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java, SolrJ
> Affects Versions: 7.5
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
> Attachments: SOLR-12947.patch
>
>
> The JSON request API is becoming increasingly popular for sending querying or
> accessing the JSON faceting functionality. The query DSL is simple and easy
> to understand, but crafting requests programmatically is tough in SolrJ.
> Currently, SolrJ users must hardcode in the JSON body they want their request
> to convey. Nothing helps them build the JSON request they're going for,
> making use of these APIs manual and painful.
> We should see what we can do to alleviate this. I'd like to tackle this work
> in two pieces. This (the first piece) would introduces classes that make it
> easier to craft non-faceting requests that use the JSON Request API.
> Improving JSON Faceting support is a bit more involved (it likely requires
> improvements to the Response as well as the Request objects), so I'll aim to
> tackle that in a separate JIRA to keep things moving.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
