Github user jimczi commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/495#discussion_r231986364
  
    --- Diff: 
lucene/core/src/java/org/apache/lucene/search/ConstantScoreScorer.java ---
    @@ -58,6 +58,14 @@ public float getMaxScore(int upTo) throws IOException {
         return score;
       }
     
    +  @Override
    +  public void setMinCompetitiveScore(float minScore) throws IOException {
    +    float minScoreDown = Math.nextDown(minScore);
    --- End diff --
    
    Since we tie-break on doc id and collect in doc id order I don't think you 
need to take the previous float here.
    The `TopScoreCollector` sets the minimum score as the next float after the 
score of the worst top document so you should not need to change the value 
here. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to