[
https://issues.apache.org/jira/browse/SOLR-12964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680359#comment-16680359
]
Mike Sokolov commented on SOLR-12964:
-------------------------------------
{quote}what do you think about making {{DocValuesIterator}} public? I see no
reason why not. I could do it here in this issue; it's minor enough.
{quote}
+1 to that - I needed to access {{DocValuesIterator}} recently in order to
write some code that operates generically on DocValues. It doesn't look as if
you did it here though?
> Use advanceExact instead of advance in a few remaining json facet use cases
> ---------------------------------------------------------------------------
>
> Key: SOLR-12964
> URL: https://issues.apache.org/jira/browse/SOLR-12964
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
> Affects Versions: 7.5
> Reporter: Tim Underwood
> Assignee: David Smiley
> Priority: Major
> Fix For: 7.6
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This updates 2 places in the JSON Facets code that uses the advance()/docID()
> pattern instead of the simpler advanceExact(). Most other usages in the
> faceting code already make use of advanceExact().
> The only remaining usage of advance() in org.apache.solr.search.facet is in:
> * UniqueAgg.BaseNumericAcc.collect
> * HLLAgg..BaseNumericAcc.collect
> The code for those of those looks very similar and probably makes sense to
> update but it would require changing the return type of the protected
> docIdSetIterator() method to return a DocValuesIterator in order to be able
> to call the advanceExact() method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
