[ 
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682914#comment-16682914
 ] 

Peter Somogyi commented on SOLR-12881:
--------------------------------------

{quote}My question is, why remove these if they are not really unused after all?
{quote}
Code cleanup. You would probably remove unused methods if you find in the 
codebase. This imports are similarly superfluous in my opinion.

My assumption is the same-package imports were introduced with refactoring and 
moving classes to different packages. The now-redundant import statements 
stayed in these files. IntelliJ wouldn't add back these import later and I 
think Eclipse wouldn't do that either.

If you think this cleanup is not needed I'm fine with that.

> Remove unneeded import statements
> ---------------------------------
>
>                 Key: SOLR-12881
>                 URL: https://issues.apache.org/jira/browse/SOLR-12881
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (8.0)
>            Reporter: Peter Somogyi
>            Assignee: Erick Erickson
>            Priority: Trivial
>         Attachments: SOLR-12881.patch, SOLR-12881.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are unnecessary import statements:
>  * import from java.lang
>  * import from same package
>  * unused import



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to