Github user cbismuth commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/496#discussion_r232665140
  
    --- Diff: 
lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ---
    @@ -68,6 +68,20 @@ public void setScorer(Scorable scorer) throws 
IOException {
       }
     
       static boolean canEarlyTerminate(Sort searchSort, Sort indexSort) {
    +    return canEarlyTerminateOnDocId(searchSort, indexSort) ||
    +           canEarlyTerminateOnPrefix(searchSort, indexSort);
    +  }
    +
    +  private static boolean canEarlyTerminateOnDocId(Sort searchSort, Sort 
indexSort) {
    +    final SortField[] fields1 = searchSort.getSort();
    +    final SortField[] fields2 = indexSort.getSort();
    +    return fields1.length == 1 &&
    --- End diff --
    
    Oh, yes, we don't need it, I'll remove these conditions.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to