[ https://issues.apache.org/jira/browse/SOLR-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694222#comment-16694222 ]
David Smiley commented on SOLR-5211: ------------------------------------ Moshe and I iterated a bit on the linked PR and I think it's ready. Proposed CHANGES.txt as follows under Improvements: {noformat} If _root_ is defined in the schema, it is now always populated automatically. This allows documents with children to be updated with a document that does not have children, whereas before it would break block-join queries. If you don't use nested documents then _root_ can be removed as always. {noformat} I plan to commit tomorrow to master only. I'll have my laptop with me over Thanksgiving holidays in case there are issues. > updating parent as childless makes old children orphans > ------------------------------------------------------- > > Key: SOLR-5211 > URL: https://issues.apache.org/jira/browse/SOLR-5211 > Project: Solr > Issue Type: Sub-task > Components: update > Affects Versions: 4.5, 6.0 > Reporter: Mikhail Khludnev > Assignee: David Smiley > Priority: Blocker > Fix For: master (8.0) > > Attachments: SOLR-5211.patch, SOLR-5211.patch, SOLR-5211.patch > > Time Spent: 3h > Remaining Estimate: 0h > > if I have parent with children in the index, I can send update omitting > children. as a result old children become orphaned. > I suppose separate \_root_ fields makes much trouble. I propose to extend > notion of uniqueKey, and let it spans across blocks that makes updates > unambiguous. > WDYT? Do you like to see a test proves this issue? -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org