[
https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man reassigned SOLR-13030:
-------------------------------
Assignee: Mark Miller (was: Andrzej Bialecki )
Description: {{MetricsHistoryHandler}} implements {{Closeable}} and depends
on it's {{close()}} method to shutdown a {{private ScheduledThreadPoolExecutor
collectService}} as well as a {{private final SolrRrdBackendFactory factory}}
(which maintains it's own {{private ScheduledThreadPoolExecutor}} but -as far
as i can tell nothing seems to every "close" this {{MetricsHistoryHandler}} on
shutdown.- after changes in 75b1831967982 which move this close() call to a
{{ForkJoinPool}} in {{CoreContainer.shutdown()}} it seems to be leaking
threads. (was: {{MetricsHistoryHandler}} implements {{Closeable}} and depends
on it's {{close()}} method to shutdown a {{private ScheduledThreadPoolExecutor
collectService}} as well as a {{private final SolrRrdBackendFactory factory}}
(which maintains it's own {{private ScheduledThreadPoolExecutor}} but as far as
i can tell nothing seems to every "close" this {{MetricsHistoryHandler}} on
shutdown.)
Digging in, i just realized the code for closing the MetricsHistoryHandler was
changed heavily by [[email protected]]'s 75b1831967982 commit in
SOLR-12932, and now happens as part of a {{customThreadPool.submit()}} in
CoreContainer.shutdown -- which is why i missed seeing it the first time i
looked.
> MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?
> ----------------------------------------------------------------------------
>
> Key: SOLR-13030
> URL: https://issues.apache.org/jira/browse/SOLR-13030
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Mark Miller
> Priority: Major
>
> {{MetricsHistoryHandler}} implements {{Closeable}} and depends on it's
> {{close()}} method to shutdown a {{private ScheduledThreadPoolExecutor
> collectService}} as well as a {{private final SolrRrdBackendFactory factory}}
> (which maintains it's own {{private ScheduledThreadPoolExecutor}} but -as far
> as i can tell nothing seems to every "close" this {{MetricsHistoryHandler}}
> on shutdown.- after changes in 75b1831967982 which move this close() call to
> a {{ForkJoinPool}} in {{CoreContainer.shutdown()}} it seems to be leaking
> threads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
