[
https://issues.apache.org/jira/browse/SOLR-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705503#comment-16705503
]
Mark Miller edited comment on SOLR-13030 at 12/1/18 12:17 AM:
--------------------------------------------------------------
I'm not sure if it's as simple as that, but for now I'll just close it inline
and see what happens since I've never seen this leak in my local runs.
was (Author: [email protected]):
I'm not sure if it's as simple as that, but for now I'll just close it inline
and what happens since I've never seen this leak in my local runs.
> MetricsHistoryHandler appears to never be "close()ed" - causes thread leaks?
> ----------------------------------------------------------------------------
>
> Key: SOLR-13030
> URL: https://issues.apache.org/jira/browse/SOLR-13030
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Mark Miller
> Priority: Major
>
> {{MetricsHistoryHandler}} implements {{Closeable}} and depends on it's
> {{close()}} method to shutdown a {{private ScheduledThreadPoolExecutor
> collectService}} as well as a {{private final SolrRrdBackendFactory factory}}
> (which maintains it's own {{private ScheduledThreadPoolExecutor}} but -as far
> as i can tell nothing seems to every "close" this {{MetricsHistoryHandler}}
> on shutdown.- after changes in 75b1831967982 which move this close() call to
> a {{ForkJoinPool}} in {{CoreContainer.shutdown()}} it seems to be leaking
> threads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
