Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/489#discussion_r238528464
  
    --- Diff: 
solr/core/src/java/org/apache/solr/update/processor/CdcrUpdateProcessor.java ---
    @@ -16,115 +16,12 @@
      */
     package org.apache.solr.update.processor;
     
    -import java.io.IOException;
    -import java.lang.invoke.MethodHandles;
    -
    -import org.apache.solr.common.params.CommonParams;
    -import org.apache.solr.common.params.ModifiableSolrParams;
    -import org.apache.solr.common.params.SolrParams;
    -import org.apache.solr.request.SolrQueryRequest;
    -import org.apache.solr.response.SolrQueryResponse;
    -import org.apache.solr.update.AddUpdateCommand;
    -import org.apache.solr.update.DeleteUpdateCommand;
    -import org.apache.solr.update.UpdateCommand;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
    -
     /**
      * <p>
    - * Extends {@link 
org.apache.solr.update.processor.DistributedUpdateProcessor} to force peer sync 
logic
    - * for every updates. This ensures that the version parameter sent by the 
source cluster is kept
    - * by the target cluster.
    + * An Interface for Shared params for Cdcr Update Processors
    --- End diff --
    
    Do we really need this interface just for this param?  I think not.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to