[ 
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713880#comment-16713880
 ] 

Ignacio Vera edited comment on LUCENE-8581 at 12/9/18 7:37 AM:
---------------------------------------------------------------

New iteration over the patch. Main changes are:
 * Change LatLonShape tests to encode/decode the resulting triangles the same 
way LatLonShape does at index time to ensure orientation consistency.
 * Remove ordering logic for polygons (tessellator) and lines.
 * Improve readability of encoding logic following Adrien's recommendation.
 *  Add test for LatLonShapeEncoding


was (Author: ivera):
New iteration over the patch. Main changes are:
 * Change LatLonShape tests to encode/decode the resulting triangles the same 
way LatLonShape does at index time to ensure orientation consistency.
 * Remove ordering logic for polygons (tessellator) and lines.
 * Improve readability of encoding logic following Adrian's recommendation.
 *  Add test for LatLonShapeEncoding

> Change LatLonShape encoding to use 4 BYTES Per Dimension
> --------------------------------------------------------
>
>                 Key: LUCENE-8581
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8581
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Nicholas Knize
>            Assignee: Ignacio Vera
>            Priority: Major
>         Attachments: LUCENE-8581.patch, LUCENE-8581.patch, LUCENE-8581.patch
>
>
> {{LatLonShape}} tessellated triangles currently use a relatively naive 
> encoding with the first four dimensions as the bounding box of the triangle 
> and the last three dimensions as the vertices of the triangle. To encode the 
> {{x,y}} vertices in the last three dimensions requires {{bytesPerDim}} to be 
> set to 8, with 4 bytes for the x & y axis, respectively. We can reduce 
> {{bytesPerDim}} to 4 by encoding the index(es) of the vertices shared by the 
> bounding box along with the orientation of the triangle. This also opens the 
> door for supporting {{CONTAINS}} queries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to