[
https://issues.apache.org/jira/browse/SOLR-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714308#comment-16714308
]
Mark Miller commented on SOLR-12801:
------------------------------------
{quote}The 2 sec wait at the end of the test, while ugly does seem to work.
{quote}
Probably a better solution is the thread leak annotation with a longer timeout.
The problem with this approach is that other tests that use this feature in the
future will introduce this rare random fail without a dev knowing.
It can be a pain, but the rule is that we have to close and clean and wait for
threads unless we really can't for some reason. Exceptions and hacks end up
hurting us over time as tests and devs evolve.
We need close to wait for any outstanding executors to finish shutting down.
> Fix the tests, remove BadApples and AwaitsFix annotations, improve env for
> test development.
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-12801
> URL: https://issues.apache.org/jira/browse/SOLR-12801
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Critical
> Time Spent: 1h
> Remaining Estimate: 0h
>
> A single issue to counteract the single issue adding tons of annotations, the
> continued addition of new flakey tests, and the continued addition of
> flakiness to existing tests.
> Lots more to come.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
