Github user barrotsteindev commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/528#discussion_r241954714
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/DistributedStandaloneUpdateProcessor.java
---
@@ -56,8 +59,15 @@ public void doDeleteByQuery(DeleteUpdateCommand cmd)
throws IOException {
super.doDeleteByQuery(cmd, Collections.emptyList(), null);
}
+ @Override
+ protected void postProcessDeleteByQuery(DeleteUpdateCommand cmd,
+ List<SolrCmdDistributor.Node>
replicas, DocCollection coll) throws IOException {
+ // no op
+ }
+
@Override
boolean isLeader(UpdateCommand cmd) {
+ updateCommand = cmd;
--- End diff --
since this is a package private method, perhaps it should be renamed to
setupRequest(like the protected methods) just that this once takes an update
command( Distributed#setupRequest(UpdateCommand cmd) ). It should be stated in
the java doc that the method returns whether this node is the leader for the
supplied update command(cmd).
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
