[ https://issues.apache.org/jira/browse/SOLR-13091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729729#comment-16729729 ]
Erick Erickson commented on SOLR-13091: --------------------------------------- This is a test-only patch illustrating the problem with distributing any shardUnique property. It doesn't matter whether the property is an arbitrary one with the shardUnique flag explicitly set or preferredLeader without shardUnique set. It doesn't matter whether the property is capitalized or not. Unfortunately, it doesn't reproduce with a particular seed, It does fail about 25% of the time when I beasted it overnight. What's particularly interesting is that when the test runs, it uses one of two methods to set the property, one with the admin API and one just making a request setting parameters. ONLY the one setting parameters fails, see: {code:java} setPropWithStandardRequest{code} All the failures are in: testBalancePropertySliceUnique I'll be digging more later, but wanted to preserve this. NOTE: the other test that sets a shardUnique property manually (and repeatedly) using one of those two methods works all the time, it's only the test that tries to have the properties distributed manually that fails. The test code is not complete, has nocommits in it and the like as well as extraneous output.... What you get is a shard with the supposedly unique property twice, e.g. {quote}"shard2":{ [junit4] > "range":"c0000000-ffffffff", [junit4] > "state":"active", [junit4] > "replicas":{ [junit4] > "core_node10": Unknown macro: \{ [junit4] > "core"} , [junit4] > "core_node11": Unknown macro: \{ [junit4] > "core"} , [junit4] > "core_node13": Unknown macro: \{ [junit4] > "core"} }}, {quote} > REBALANCELEADERS is broken > -------------------------- > > Key: SOLR-13091 > URL: https://issues.apache.org/jira/browse/SOLR-13091 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrCloud > Affects Versions: 7.6 > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Major > Attachments: SOLR-13091.patch > > > From the user's list, the REBALANCELEADERS API doesn't seem to work > correctly. Manual testing shows the problem. > It's disturbing that the unit test doesn't catch this. That'll be the first > thing to fix. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org