[ 
https://issues.apache.org/jira/browse/LUCENE-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082847#comment-13082847
 ] 

Robert Muir commented on LUCENE-3357:
-------------------------------------

Ok I added some things (marked nocommit for your review):

Basically we have the case for norms/totalTermFreq/sumTotalTermFreq that they 
can be unavailable because
freqs or norms are omitted, but currently all sims have to deal with this 
problem :(

Ideally sims would not have to deal with this stuff, but for the time being it 
prevents NaN/Inf for the hearts test
if the test gets preflexcodec (about 1/4 of the time), and it will prevent NPE 
if norms are omitted.

in the case these values are unavailable i set these to "1"... if you can 
review that this is ok, we can nuke the nocommits.

> Unit and integration test cases for the new Similarities
> --------------------------------------------------------
>
>                 Key: LUCENE-3357
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3357
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring
>    Affects Versions: flexscoring branch
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>            Priority: Minor
>              Labels: gsoc, gsoc2011, test
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, 
> LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, LUCENE-3357.patch, 
> LUCENE-3357.patch, LUCENE-3357.patch
>
>
> Write test cases to test the new Similarities added in 
> [LUCENE-3220|https://issues.apache.org/jira/browse/LUCENE-3220]. Two types of 
> test cases will be created:
>  * unit tests, in which mock statistics are provided to the Similarities and 
> the score is validated against hand calculations;
>  * integration tests, in which a small collection is indexed and then 
> searched using the Similarities.
> Performance tests will be performed in a separate issue.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to