[
https://issues.apache.org/jira/browse/SOLR-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735128#comment-16735128
]
mosh commented on SOLR-12888:
-----------------------------
[~dsmiley],
The patch looks good.
I liked how in TestNestedUpdateProcessor the "nested" URP chain is used, having
this processor explicitly added,
while TestChildDocTransformerHierarchy uses the default URP, ensuring this is
activated implicitly.
I do have a minor comment to share with you though, it is a very minor,
basically just me thinking out loud.
I much prefer the use of Java 8's Map#computeIfAbsent, instead of
Map#putIfAbsent, since the former does not compute the value if the key already
exists.
So I'd prefer if SolrCore#getStatsCache:1457: would be change from:
{code:java}
map.putIfAbsent(RunUpdateProcessorFactory.PRE_RUN_CHAIN_NAME,
new UpdateRequestProcessorChain(Collections.singletonList(new
NestedUpdateProcessorFactory()), this));{code}
to:
{code:java}
map.computeIfAbsent(RunUpdateProcessorFactory.PRE_RUN_CHAIN_NAME,
k -> new UpdateRequestProcessorChain(Collections.singletonList(new
NestedUpdateProcessorFactory()), this));{code}
This would prevent from a new URP chain being constructed if the key is already
present in the map.
There is a chance I am just being fussy, since currently the key would only
exists if the user explicitly defined it in the config.
> NestedUpdateProcessor code should activate automatically in 8.0
> ---------------------------------------------------------------
>
> Key: SOLR-12888
> URL: https://issues.apache.org/jira/browse/SOLR-12888
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: master (8.0)
>
> Attachments: SOLR-12888.patch
>
>
> If the schema supports it, the NestedUpdateProcessor URP should be registered
> automatically somehow. The Factory for this already looks for the existence
> of certain special fields in the schema, so that's good. But the URP Factory
> needs to be added to your chain in any of the ways we support that. _In 8.0
> the user shouldn't have to do anything to their solrconfig._
> We might un-URP this and call directly somewhere. Or perhaps we might add a
> special named URP chain (needn't document), defined automatically, that
> activates at RunURP. Perhaps other things could be added to this in the
> future.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
