[
https://issues.apache.org/jira/browse/SOLR-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735478#comment-16735478
]
David Smiley commented on SOLR-12365:
-------------------------------------
Doh! Thanks Shalin! My IDE modules/config was out of date so my refactor
missed this. I did run "ant precommit" but apparently it didn't catch the need
to recompile. Had I ran tests it would have I figure. Perhaps a future Gradle
based build might make this easier to prevent at the precommit stage.
> Rename Config.java to XmlConfigFile.java to clarify it's use
> ------------------------------------------------------------
>
> Key: SOLR-12365
> URL: https://issues.apache.org/jira/browse/SOLR-12365
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: master (8.0)
>
> Attachments:
> move_luceneMatchVersion_parsing_to_SolrConfig_from_XmlConfigFile.patch
>
>
> Seeing "Config"; I was confused what sort of config it was. Turns out it's a
> wrapper around an XML document providing some convenience methods around it.
> It ought to have class javadocs too. XmlConfigFile would be a clearer name
> IMO.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
