[
https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738436#comment-16738436
]
David Smiley commented on SOLR-12304:
-------------------------------------
Okay; deprecate then delete just the handler then. That can be worked out in
another issue. It's debatable wether that's 8.0 dependent, I suppose.
Yes this patch seems valid.
I took a little look at the patch. In the spot where you create
interestingTermsResponse, you used a NamedList. But I think a SimpleOrderedMap
since the keys will not repeat (that's the difference – yeah I know that's
confusing). Otherwise it seems good. I like all the tests.
Curious; why do you consider this a bug? Seems like an enhancement to the MLT
component.
> Interesting Terms parameter is ignored by MLT Component
> -------------------------------------------------------
>
> Key: SOLR-12304
> URL: https://issues.apache.org/jira/browse/SOLR-12304
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: MoreLikeThis
> Affects Versions: 7.2
> Reporter: Alessandro Benedetti
> Priority: Major
> Attachments: SOLR-12304.patch, SOLR-12304.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the More Like This component just ignores the mlt.InterestingTerms
> parameter ( which is usable by the MoreLikeThisHandler).
> Scope of this issue is to fix the bug and add related tests ( which will
> succeed after the fix )
> *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the
> tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent
> ones .
> It is out of scope for this issue any consideration or refactor of that.
> Other issues will follow.
> *N.B.* out of scope for this issue is the distributed case, which is much
> more complicated and requires much deeper investigations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
