[ 
https://issues.apache.org/jira/browse/SOLR-13118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man resolved SOLR-13118.
-----------------------------
       Resolution: Fixed
    Fix Version/s: master (9.0)
                   7.7
                   8.0

this is looking pretty good

> Redesign integration tests for nodeAdded/nodeLost trigger state restoration
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-13118
>                 URL: https://issues.apache.org/jira/browse/SOLR-13118
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>             Fix For: 8.0, 7.7, master (9.0)
>
>         Attachments: SOLR-13118.patch
>
>
> The (integration) tests related to autoscaling nodeAdd/nodeLost trigger's and 
> restoring their state are problematic for a lot of reasons.
> Beyond some silly implementation mistakes, a fundemental timing/concurrency 
> issue is that (as designed) the tests have no way to ensure that "after" 
> creating a nodeAdded/nodeLost situation, they can wait for the (first 
> instance of) the trigger to run() and detect the situation (recording it in 
> the trigger's internal state) so that the test can subsequently "update" the 
> trigger, forcing a new instance to restore the old state and then execute the 
> trigger actions.  This can result i na lot of flaky-ness if the triggers 
> don't run when "expected"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to