[ 
https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744887#comment-16744887
 ] 

Andrzej Bialecki  commented on SOLR-13140:
------------------------------------------

bq. ... can you please clarify what you mean by "a (currently unsupported) 
DELETENODE request" ? 
Sorry, please ignore that part - I mixed this up with another operation. This 
is definitely supported (via {{DeleteNodeSuggester}}.

bq. Unless the underlying Collections API impl of DELETENODE is smart enough 
not to shutdown a leader (or the last remaining replica) this definitely seems 
like a bug.

Correct, it's a bug - {{SearchRateTrigger.calculateColdOps}} has a section at 
the end when {{belowNodeOp != null}} and there it should protect leader nodes 
from being deleted. There's also a non-javadoc comment there about the dangers 
of this functionality, which is also mentioned in the Ref Guide (but perhaps 
should be turned into a NOTE?).

> Harden SearchRateTriggerIntegrationTest
> ---------------------------------------
>
>                 Key: SOLR-13140
>                 URL: https://issues.apache.org/jira/browse/SOLR-13140
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>         Attachments: SOLR-13140.patch, SOLR-13140.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to