tokee commented on a change in pull request #525: LUCENE-8585: Index-time
jump-tables for DocValues
URL: https://github.com/apache/lucene-solr/pull/525#discussion_r248948819
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
##########
@@ -1216,7 +1219,7 @@ private void doTestNumericsVsStoredFields(double
density, LongSupplier longs) th
doc.add(dvField);
// index some docs
- int numDocs = atLeast(300);
+ int numDocs = atLeast((int) (minDocs*1.172));
Review comment:
Yeah, that should have been explained. It is because I made the minDocs
variable. Originally the test was fixed with 256 as minDocs. `256*1.172=300`,
so with this trick the `numDocs/minDocs`-factor stayed constant for the old
tests. I have probably been overthinking this. Should I set it to something
less puzzling like 1.5 or 2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
