[ https://issues.apache.org/jira/browse/LUCENE-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746287#comment-16746287 ]
Dawid Weiss commented on LUCENE-8474: ------------------------------------- The PR removing RAMDirectory is here: https://github.com/apache/lucene-solr/pull/543 There are two things that probably require your attention: 1) The NRTDirectory required some adjustments because it relied on methods that are no longer available. The "current size" is, for example, maintained inside NRTDirectory and not in the target cache's store. https://github.com/apache/lucene-solr/pull/543/commits/83195788268ab0010f43f279af31d1f530acaeeb I also removed one of the locks in {{unCache}} because the benefits seemed marginal (two locks always had to be acquired). 2) I don't know what to do with Solr. I changed RAMDirectoryFactory to return the new ram-resident directory implementation, but the name of that factory is *everywhere*. Don't know whether we want to rename this factory or leave it as-is, with a different internal implementation. https://github.com/apache/lucene-solr/pull/543/commits/91eb67f48051826c58feed4380501e605c317e54 > Remove deprecated RAMDirectory > ------------------------------ > > Key: LUCENE-8474 > URL: https://issues.apache.org/jira/browse/LUCENE-8474 > Project: Lucene - Core > Issue Type: Sub-task > Reporter: Dawid Weiss > Assignee: Dawid Weiss > Priority: Major > Fix For: master (9.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Placeholder for the remainder of the original patch, removing all > 8.x-deprecated RAMDirectory classes and replacing their use cases with > ByteBuffersDirectory. > This will have to wait until branch 8.x is officially cut. > Local branch with RAMDirectory related classes removed (pending 8.x branch, > will be updated then). > https://github.com/dweiss/lucene-solr/tree/LUCENE-8438 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org