[
https://issues.apache.org/jira/browse/SOLR-13145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746445#comment-16746445
]
Cassandra Targett commented on SOLR-13145:
------------------------------------------
+1 for the simple change in the patch.
bq. What if the ant build inside solr-ref-guide did a check for all gems and
versions as the very first task?
Great idea, but would require a bit more surgery. IMO, let's not hold up a
simple fail-on-error for something more complex unless Gus or you or someone
else has time to implement it relatively soon. Failure when the biggest thing
you need is missing is a positive incremental improvement.
> Provide better error when ref guide deps are not installed
> ----------------------------------------------------------
>
> Key: SOLR-13145
> URL: https://issues.apache.org/jira/browse/SOLR-13145
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Affects Versions: 8.0
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Trivial
> Attachments: SOLR-13145.patch
>
>
> Recently I tried to build the ref guide only to find I didn't have the deps
> installed on that particular machine (mostly I do solr dev on my desktop
> cause it's faster). The error I got was unenlightening:
> {code:java}
> build-site:
> [java] Exception in thread "main" java.lang.NullPointerException
> [java] at CheckLinksAndAnchors.main(CheckLinksAndAnchors.java:156)
> BUILD FAILED
> {code}
> This happens because CheckLinksAndAnchors.main() is trying to list the files
> in the directory into which Jeckyll didn't put the html.... and getting null.
> I think the problem here is that we let the build continue when Jeckyll
> failed. Attaching patch to fail out when Jeckyll is not found with this
> message:
> {code:java}
> -build-site:
> [echo] Running Jekyll...
> [exec] rbenv: jekyll: command not found
> BUILD FAILED
> /Users/gus/projects/solr/lucene-solr/solr/solr-ref-guide/build.xml:299: exec
> returned: 127
> {code}
> That at least will point the dev in the right direction, since clearly
> something required is not found.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
