[ 
https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752816#comment-16752816
 ] 

ASF subversion and git services commented on SOLR-12313:
--------------------------------------------------------

Commit b7a8ca98b6e42e1d48952cd20f1957c19cf3b73b in lucene-solr's branch 
refs/heads/branch_7x from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b7a8ca9 ]

SOLR-13168: Fixed a bug in TestInjection that caused test only code to be 
invoked when TLOG replicas recieved commits if java assertions were enabled

(see also: SOLR-12313)

(cherry picked from commit ec6835906518b97ea03bbdb3b01442711cf9f943)


> TestInjection#waitForInSyncWithLeader needs improvement.
> --------------------------------------------------------
>
>                 Key: SOLR-12313
>                 URL: https://issues.apache.org/jira/browse/SOLR-12313
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Priority: Major
>
> This really should have some doc for why it would be used.
> I also think it causes BasicDistributedZkTest to take forever for sometimes 
> and perhaps other tests?
> I think checking for uncommitted data is probably a race condition and should 
> be removed.
> Checking index versions should follow the rules that replication does - if 
> the slave is higher than the leader, it's in sync, being equal is not 
> required. If it's expected for a test it should be a specific test that 
> fails. This just introduces massive delays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to