risdenk commented on issue #553: SOLR-9515: Update to Hadoop 3 URL: https://github.com/apache/lucene-solr/pull/553#issuecomment-458978258 @uschindler yea so I tried fixing a lot of the failures. Some up the issues I ran into: * Changing LOG -> log to match the source patterns check broke other Hadoop classes. It turns out Hadoop uses the LOG since it is public outside the HttpServer2 class. I couldn't find a way to suppress just the source check for that file. * Forbiddenapis (even with SuppressForbidden) kept saying that https://github.com/apache/hadoop/blob/branch-3.2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java#L1500 was invalid due to https://github.com/apache/lucene-solr/blob/master/lucene/tools/forbiddenApis/servlet-api.txt#L18. I tried to add SuppressForbidden at the class, static class, method, and override methods to fix the issue, but the errors still came back. So with the above two issues that is how I ended up suppressing the checks on the HttpServer2 class. The other thought I had is that it would be nice to not edit HttpServer2 too much in case we need to copy changes back from Apache Hadoop again. I am open to suggestions on how to move forward without suppressing the checks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
