[
https://issues.apache.org/jira/browse/SOLR-13203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757319#comment-16757319
]
Johannes Kloos commented on SOLR-13203:
---------------------------------------
Going over our examples where a 500 status code was returned, I noticed that a
number of other exceptions are also used to report invalid user input, but
yield 500 errors. In particular, I think it would make sense to have the
following exceptions give a 400 status code, at least in some cases:
- SOLRException
- NumberFormatException
- IllegalArgumentException
- IOException
- JSONParser.ParserException
- UnsupportedCharsetExecption
Additionally, I found one case of UnsupportedOperationException that should
probably report a 400 instead of a 500. It is thrown at
org.apache.lucene.search.Query.createWeight(Query.java:66).
> RuntimeException causing a 500 response code for invalid user input
> -------------------------------------------------------------------
>
> Key: SOLR-13203
> URL: https://issues.apache.org/jira/browse/SOLR-13203
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Affects Versions: master (9.0)
> Environment: h1. Steps to reproduce
> * Use a Linux machine.
> * Build commit {{ea2c8ba}} of Solr as described in the section below.
> * Build the films collection as described below.
> * Start the server using the command {{./bin/solr start -f -p 8983 -s
> /tmp/home}}
> * Request the URL given in the bug description.
> h1. Compiling the server
> {noformat}
> git clone https://github.com/apache/lucene-solr
> cd lucene-solr
> git checkout ea2c8ba
> ant compile
> cd solr
> ant server
> {noformat}
> h1. Building the collection
> We followed [Exercise
> 2|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html#exercise-2] from
> the [Solr
> Tutorial|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html]. The
> attached file ({{home.zip}}) gives the contents of folder {{/tmp/home}} that
> you will obtain by following the steps below:
> {noformat}
> mkdir -p /tmp/home
> echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' >
> /tmp/home/solr.xml
> {noformat}
> In one terminal start a Solr instance in foreground:
> {noformat}
> ./bin/solr start -f -p 8983 -s /tmp/home
> {noformat}
> In another terminal, create a collection of movies, with no shards and no
> replication, and initialize it:
> {noformat}
> bin/solr create -c films
> curl -X POST -H 'Content-type:application/json' --data-binary '{"add-field":
> {"name":"name", "type":"text_general", "multiValued":false, "stored":true}}'
> http://localhost:8983/solr/films/schema
> curl -X POST -H 'Content-type:application/json' --data-binary
> '{"add-copy-field" : {"source":"*","dest":"_text_"}}'
> http://localhost:8983/solr/films/schema
> ./bin/post -c films example/films/films.json
> {noformat}
> Reporter: Johannes Kloos
> Priority: Trivial
> Labels: diffblue, newdev
> Attachments: home.zip
>
>
> Requesting the following URL causes Solr to return an HTTP 500 error response:
> {noformat}
> http://localhost:8983/solr/films/select?uf=fl=gen*,id&defType=edismax
> {noformat}
> The error response seems to be caused by the following uncaught exception:
> {noformat}
> java.lang.RuntimeException: dynamic field name must start or end with *
> at
> org.apache.solr.search.ExtendedDismaxQParser$DynamicField.<init>(ExtendedDismaxQParser.java:1610)
> {noformat}
> The DynamicField parser throws this RuntimeException to tell the user that
> the given query is invalid. Sadly, the exception is never caught, so it
> manifests as a 500 error instead of a 400 error.
> We found this issue and ~70 more like this using [Diffblue Microservices
> Testing|https://www.diffblue.com/labs/?utm_source=solr-br]. Find more
> information on this [fuzz testing
> campaign|https://www.diffblue.com/blog/2018/12/19/diffblue-microservice-testing-a-sneak-peek-at-our-early-product-and-results?utm_source=solr-br].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
