jpountz commented on issue #562: Don't create a LeafCollector when the Scorer for the leaf is null URL: https://github.com/apache/lucene-solr/pull/562#issuecomment-460812077 I had considered something like that in the past but didn't like the fact that it made things slower with queries whose bulk scorer is costly to create (eg. range or multi-term) and collectors that can skip entire segments by raising a `CollectionTerminatedException` in `getLeafCollector`. Maybe we could have a way to construct bulk scorers in two steps similarly to `Weight#scorerSupplier` for regular scorers so that we could check whether a bulk scorer might have any hits without paying the full construction price. I expect this would only help if a leaf collector is expensive to construct, with which collector are you seeing slowdowns because Lucene is constructing leaf collectors on segments that don't have matches?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
