jpountz commented on a change in pull request #556: LUCENE-8673: Use radix
partitioning when merging dimensional points
URL: https://github.com/apache/lucene-solr/pull/556#discussion_r254264432
##########
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextBKDWriter.java
##########
@@ -1337,12 +1093,12 @@ private void build(int nodeID, int leafNodeOffset,
@Override
public BytesRef apply(int i) {
- heapSource.getPackedValueSlice(Math.toIntExact(source.start + i),
scratch);
+ heapSource.getPackedValueSlice(Math.toIntExact(i), scratch);
Review comment:
no need for toIntExact?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
