gus-asf commented on a change in pull request #573: WIP: SOLR-13150
URL: https://github.com/apache/lucene-solr/pull/573#discussion_r257879138
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CategoryRoutedAlias.java
##########
@@ -125,13 +146,13 @@ String buildCollectionNameFromValue(String value) {
@Override
public String createCollectionsIfRequired(AddUpdateCommand cmd) {
+ assert
!getCollectionList(this.parsedAliases).contains(buildCollectionNameFromValue(String.valueOf(cmd.getSolrInputDocument().getFieldValue(getRouteField()))));
Review comment:
This assert is not correct... the method is createCollections--if--required.
meaning it might not be required (because it might already exist) I'll remove
this. (and add some nice javadoc to make this clearer :) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
