mikemccand commented on a change in pull request #579: PET: prorated early
termination
URL: https://github.com/apache/lucene-solr/pull/579#discussion_r258158795
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -100,8 +101,8 @@ private static boolean canEarlyTerminateOnPrefix(Sort
searchSort, Sort indexSort
final Sort sort;
final FieldValueHitQueue<Entry> queue;
- public SimpleFieldCollector(Sort sort, FieldValueHitQueue<Entry> queue,
int numHits, int totalHitsThreshold) {
- super(queue, numHits, totalHitsThreshold, sort.needsScores());
+ public SimpleFieldCollector(Sort sort, FieldValueHitQueue<Entry> queue,
int numHits, int totalHitsThreshold, int perSegmentMargin) {
Review comment:
Maybe add javadocs here linking to the nice docs in the `create` methods
below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
