[
https://issues.apache.org/jira/browse/LUCENE-8701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772231#comment-16772231
]
Adrien Grand commented on LUCENE-8701:
--------------------------------------
+1 I think some more comments could make it easier to read. Could create the
child weight with ScoreMode.COMPLETE_NO_SCORES when childScoreMode is None
regardless of the scoreMode that is passed to createWeight?
> Speed up ToParentBlockJoinQuery when total hit count is not needed
> ------------------------------------------------------------------
>
> Key: LUCENE-8701
> URL: https://issues.apache.org/jira/browse/LUCENE-8701
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Jim Ferenczi
> Priority: Minor
> Attachments: LUCENE-8701.patch
>
>
> We spotted a regression on nested queries in the Elastisearch nightly track:
> https://elasticsearch-benchmarks.elastic.co/index.html#tracks/nested/nightly/30d
> It seems related to the fact that we propagate the TOP_SCORES score mode to
> the child query even though we don't compute a max score in the
> BlockJoinScorer and don't propagate the minimum score either. Since it is not
> possible to compute a max score for a document that depends on other
> documents (the children) we should probably force the score mode to COMPLETE
> to build the child scorer. This should avoid the overhead of loading and
> reading the impacts. It should also be possible to early terminate queries
> that use the ScoreMode.None mode since in this case the score of each parent
> document is the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
