gus-asf commented on a change in pull request #583: SOLR-13151
URL: https://github.com/apache/lucene-solr/pull/583#discussion_r258972041
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
##########
@@ -1652,15 +1654,21 @@ public CreateCategoryRoutedAlias setMaxCardinality(int
maxCardinality) {
return this;
}
+ public CreateCategoryRoutedAlias setMustMatch(String regex) {
+ this.mustMatch = regex;
+ return this;
+ }
+
@Override
public SolrParams getParams() {
ModifiableSolrParams params = (ModifiableSolrParams) super.getParams();
params.add(CommonParams.NAME, aliasName);
params.add(ROUTER_TYPE_NAME, "category");
params.add(ROUTER_FIELD, routerField);
+ params.add(ROUTER_MAX_CARDINALITY, maxCardinality.toString());
- if (maxCardinality != null) {
- params.add(ROUTER_MAX_CARDINALITY, maxCardinality.toString());
+ if (mustMatch != null) {
Review comment:
Reading this on github, so maybe I'm reading it wrong, but won't mustMatch
always start out null and this check won't ever pass?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
