msokolov commented on issue #580: LUCENE-8700: IndexWriter.yield()
URL: https://github.com/apache/lucene-solr/pull/580#issuecomment-466071398
 
 
   OK, so `IndexWriter#flushNextBuffer()` seems to do just what we need; I get 
basically the same behavior by just replacing `yield()` with that. The other 
notable thing in this patch is having `RandomIndexWriter.commit()` sometimes 
call that during tests. I see there are some explicit tests of 
`flushNextBuffer` in `IndexWriterTest`, but I wonder if you see any value in 
adding this concurrent flushing to lots more tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to