[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776297#comment-16776297
]
Erick Erickson commented on SOLR-13268:
---------------------------------------
I got a clean test run with the shutdown in StartupLoggingUtils commented
completely out. Although that's weird enough that I'll double check it in a bit.
So assuming precommit passes and I really did comment the shutdown bit out,
I'll put up a patch and push the code this morning.
Let's assume all that works and Kevin's changes fix up the leaks. WDYT about
1> rolling back all the test cases where I changed the superclass from
LuceneTestCase to SolrTestCaseJ4? Is there any reason to?
2> rolling back the changes to StartupLoggingUtils?
I'll do both unless there are objections, the additions to StartupLoggingUtils
in particular is cruft.
All bets are off of course if we still have problems, I'll un-comment the
shutdown in StartupLoggingUtils in tat case and we'll see.
Wish I could get this stuff to fail locally. I beasted 1,000 times with a bunch
12 in parallel and no failures.
> Clean up any test failures resulting from SOLR-12055 (async logging)
> --------------------------------------------------------------------
>
> Key: SOLR-13268
> URL: https://issues.apache.org/jira/browse/SOLR-13268
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set"
> here, these are likely systemic, once the root cause is found/fixed, then
> others are likely fixed as well.
> JDK13:
> ant test -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
