dsmiley commented on issue #581: LUCENE-3041: QueryVisitor URL: https://github.com/apache/lucene-solr/pull/581#issuecomment-467462766 I can understand that the default implementation of Query.visit is to call visitLeaf on itself for the benefit of backwards compatibility. That said, I think it's trappy for all the custom Query's out there. On master branch it ought to be an abstract method.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org