[ https://issues.apache.org/jira/browse/SOLR-13271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779658#comment-16779658 ]
Shalin Shekhar Mangar commented on SOLR-13271: ---------------------------------------------- Thanks Andrzej. A few comments: # Using property makes the API a little awkward, it should be a primary attribute I think. # I think the override is dangerous. It removes all guarantees that makes a read only mode useful such as being able to safely restore to a snapshot or blue/green deployment switch with major version upgrades etc. # I think the guarantees here are weak e.g. I see that the index writer is still open in a read only collection, should it be so? Updates can keep coming in during the reload and might be indexed by the new index writer and then auto commit will end up creating new segments and maybe even trigger a merge. Similarly, since the readOnly param is set only at the DUP construction, a long running update request can keep streaming in even after the readOnly mode is activated. # We should be careful to document that setting the readOnly mode can take a long time because the reload can cause IW.close which can trigger merges etc. > Implement a read-only mode for a collection > ------------------------------------------- > > Key: SOLR-13271 > URL: https://issues.apache.org/jira/browse/SOLR-13271 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) > Affects Versions: 8.x, master (9.0) > Reporter: Andrzej Bialecki > Assignee: Andrzej Bialecki > Priority: Major > Fix For: 8.x, master (9.0) > > Attachments: SOLR-13271.patch > > > Spin-off from SOLR-11127. In some scenarios it's useful to be able to block > any updates to a collection, while still being able to search its contents. > Currently the scope of this issue is SolrCloud, ie. standalone Solr will not > be supported. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org