[
https://issues.apache.org/jira/browse/SOLR-13276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16780673#comment-16780673
]
Cao Manh Dat edited comment on SOLR-13276 at 2/28/19 4:02 PM:
--------------------------------------------------------------
Updated patch that passes tests. I added 3 base classes (most of the logic is
moved to the base class), so the structure for solrj clients will be
* HttpClusterStateProvider extends BaseHttpClusterStateProvider
* Http2ClusterStateProvider extends BaseHttpClusterStateProvider
* CloudSolrClient extends BaseCloudSolrClient
* CloudHttp2SolrClient extends BaseCloudSolrClient
For inner classes, like {{CloudSolrClient.RouteResponse}} and
{{CloudSolrClient.RouteException}} are also extends inner classes of
{{BaseCloudSolrClient}} (they are not get deleted because of
backward-compatibility). Since I don't like the idea of BaseCloudSolrClient
points to an inner class of its child classes. It also makes us harder to wipe
out apache httpClient in the future.
Other inner classes are handled same way.
was (Author: caomanhdat):
Updated patch that passes tests. I added 3 base classes (most of the logic is
moved to the base class), so the structure for solrj clients will be
* HttpClusterStateProvider extends BaseHttpClusterStateProvider
* Http2ClusterStateProvider extends BaseHttpClusterStateProvider
* CloudSolrClient extends BaseCloudSolrClient
* CloudHttp2SolrClient extends BaseCloudSolrClient
For inner classes, like {{CloudSolrClient.RouteResponse}} and
{{CloudSolrClient.RouteException}} are also extends inner classes of
{{BaseCloudSolrClient}} (they are not get deleted because of
backward-compatibility). Since I don't like the idea of BaseCloudSolrClient
points to an inner class of its child classes. It also makes us harder to wipe
out apache httpClient in the future.
> Adding Http2 equivalent classes of CloudSolrClient and
> HttpClusterStateProvider
> --------------------------------------------------------------------------------
>
> Key: SOLR-13276
> URL: https://issues.apache.org/jira/browse/SOLR-13276
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Cao Manh Dat
> Assignee: Cao Manh Dat
> Priority: Major
> Attachments: SOLR-13276.patch, SOLR-13276.patch, SOLR-13276.patch
>
>
> Before we can move on and wipe out the usage of apache httpclient inside
> Solr-core. We need to create Http/2 equivalent classes of CloudSolrClient and
> HttpClusterStateProvider
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
