[
https://issues.apache.org/jira/browse/SOLR-13151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782851#comment-16782851
]
Gus Heck edited comment on SOLR-13151 at 3/3/19 8:25 PM:
---------------------------------------------------------
Just noticed that the implementation is actually checking the collection name
not the route field value. This is not as good because the user may want to
fail on non-english values rather than allowing categories consisting of only
underlines characters to be created or otherwise fail on values that would be
eliminated by the collection naming code. This will be fixed along with the
merge of the PR on SOLR-13152 The unit test will also be updated, since it
happened to test a regex enforcing a suffix, thus missing this distinction.
was (Author: gus_heck):
Just noticed that the implementation is actually checking the collection name
not the route field value. This is not as good because the user may want to
fail on non-english values rather than allowing categories consisting of only
underlines characters to be created or otherwise fail on values that would be
eliminated by the collection naming code. This will be fixed along with the
merge of the PR on SOLR-13152
> Provide regex based category validation for CategoryRoutedAliases
> -----------------------------------------------------------------
>
> Key: SOLR-13151
> URL: https://issues.apache.org/jira/browse/SOLR-13151
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: UpdateRequestProcessors
> Affects Versions: master (9.0)
> Reporter: Gus Heck
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This ticket will add the check to enforce a (configurable, optional) regular
> expression to enreject requests that attempt to add an unexpected category,
> or a malformed category to a category routed alias. The purpose of this check
> is to provide a safety valve to ensure that unexpected data values don't
> cause creation of collections inconsistent with the user's intended design.
> This check should happen within the validateRouteValue() method specified by
> RoutedAlias
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
