That’s nasty; please fix it :-)

On Wed, Mar 6, 2019 at 5:38 PM Gus Heck <[email protected]> wrote:

> I'm wondering what the logic behind eating this exception might be? Is
> there a good reason for it? (I'm having trouble thinking of one)
>
> @Override
> public IndexableField createField(SchemaField field, Object value) {
>   IndexableField f = null;
>   try {
>     f = fromString(field, String.valueOf(value));
>   } catch (Exception e) {
>     log.warn("Error parsing pre-analyzed field '" + field.getName() + "'", e);
>     return null;
>   }
>   return f;
> }
>
> It seems to me I'd want to know if the contents of a preanalyzed field
> were unparsable every bit as much as I'd want to know about a badly
> formatted date? Just came to the realization that a unit test for some code
> I'm working was giving false positives...
>
> -Gus
>
>
> --
Sent from Gmail Mobile

Reply via email to