romseygeek commented on issue #581: LUCENE-3041: QueryVisitor URL: https://github.com/apache/lucene-solr/pull/581#issuecomment-470512093 Adding an explicit implementation on every class here has made me rethink how we're dealing with things like `TermInSetQuery`, which currently doesn't call `consumeTerms` at all; this is copied from its `extractTerms` implementation, which did nothing so as to protect highlighters, but I think this is incorrect. One idea would be to change the `Query.visit` method to take a `Predicate<String>` field selector; that way highlighters that aren't interested in the field that a `TermInSetQuery` is applied to can avoid dealing with its large set of terms, but we can still access those terms if need be.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
