[ 
https://issues.apache.org/jira/browse/LUCENE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088743#comment-13088743
 ] 

David Mark Nemeskey commented on LUCENE-3391:
---------------------------------------------

(1) I was also hesitant to add the generics, because I wasn't sure about the 
warnings it gave. So I'll remove that happily.
(2) And I guess the method parameter in queryNorm?
(3) I'm pretty bad at naming things, so I'd take your advice in this. :) Is 
BasicSimilarityProvider OK?

> Make EasySimilarityProvider a full-fledged class 
> -------------------------------------------------
>
>                 Key: LUCENE-3391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3391
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/query/scoring, general/javadocs
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc, gsoc2011, rank, similarity
>             Fix For: flexscoring branch
>
>         Attachments: LUCENE-3391.patch, LUCENE-3391.patch, LUCENE-3391.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The {{EasySimilarityProvider}} in {{TestEasySimilarity}} would be a good 
> candidate for a full-fledged class. Both {{DefaultSimilarity}} and 
> {{BM25Similarity}} have their own providers, which are effectively the 
> same,so I don't see why we couldn't add one generic provider for convenience.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to